Skip to content

Conversation

@alanprot
Copy link

Change TypeTable in WordDelimiterTokenFilter from string to List

The field "type_table" in token filter of type "word_delimiter' should be an array of strings or a object.

Ex:

{
  "settings": {
    "index": {
      "number_of_replicas": 1,
      "number_of_shards": 5,
      "analysis": {
        "analyzer": {
          "default": {
            "tokenizer": "keyword",
            "filter": [
              "wordelimiter"
            ],
            "type": "custom"
          }
        },
        "filter": {
          "wordelimiter": {
            "preserve_original": true,
            "type_table": [
              "# => ALPHA",
              "@ => ALPHA",
              ". => ALPHA"
            ],
            "type": "word_delimiter"
          }
        }
      }
    }
  }
}

@alanprot
Copy link
Author

I have signed the CLA.

@Mpdreamz
Copy link
Member

Thanks for the PR @alanprot much appreciated.

As is we can't pull it in develop because it is a breaking change can you ammend this commit:

[Obsoleting("message", true)] TypeTable marking it as a bad mapping.

Add a TypeTableList property that has the JsonProperty("type_table").

In NEST 2.0 we will rectify it properly again.

originally reported here

Mpdreamz added a commit that referenced this pull request Jul 27, 2015
1500 - Change TypeTable in WordDelimiterTokenFilter from string to Li…
@Mpdreamz Mpdreamz merged commit 06fa1ed into elastic:develop Jul 27, 2015
@Mpdreamz
Copy link
Member

LGTM 👍 thanks for amending the PR!

@alanprot
Copy link
Author

Thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants